feat: sdk consumes context engine #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaimwa9
changed the title
khvn26
requested changes
Nov 3, 2025
Comment on lines
+106
to
+111
| # Floats/doubles are not supported by the engine due to ambiguous serialization across supported platforms. (segments/models_spec.rb) | ||
| return false unless trait_value.is_a?(String) || trait_value.is_a?(Integer) | ||
|
|
||
| if @value.is_a?(Array) | ||
| return @value.include?(trait_value.to_s) | ||
| end |
There was a problem hiding this comment.
According to Flagsmith/engine-test-data#38, we only skip booleans now:
Suggested change
| # Floats/doubles are not supported by the engine due to ambiguous serialization across supported platforms. (segments/models_spec.rb) | |
| return false unless trait_value.is_a?(String) || trait_value.is_a?(Integer) | |
| if @value.is_a?(Array) | |
| return @value.include?(trait_value.to_s) | |
| end | |
| (segments/models_spec.rb) | |
| return false unless ![true, false].include? trait_value | |
| if @value.is_a?(Array) | |
| return @value.include?(trait_value.to_s) | |
| end |
| "This indicates a bug in the SDK, please report it." | ||
| end | ||
|
|
||
| acc[normalize_key(flag_result[:name])] = Flagsmith::Flags::Flag.new( |
There was a problem hiding this comment.
Why do we need to normalise the feature name?
| # Flags engine methods | ||
| # NOTE: This class is kept for backwards compatibility but no longer contains | ||
| # the old model-based evaluation methods. Use the context-based evaluation | ||
| # via Flagsmith::Engine::Evaluation::Core.get_evaluation_result instead. |
There was a problem hiding this comment.
Since we're major-versioning anyway, can we either remove the class altogether, add Flagsmith::Engine::get_evaluation_result interface? I don't see how an empty Engine class helps to maintain backwards compatibility here?
khvn26
reviewed
Nov 3, 2025
| # frozen_string_literal: true | ||
|
|
||
| require 'json' | ||
| require 'jsonpath' |
There was a problem hiding this comment.
I thought JSONPath part was moved to #88? Should this PR get rebased?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #81
In this 3/3 PR related to evaluation context in local evaluation mode
In this PR: